Implement <disableVolume at <storage>

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start by tracing how storage handles activeVolume definitions and how detector volumes register energy deposits. Define the behavior for storage configurations using disableVolume, including the rule for choosing between activeVolume and disableVolume, then verify that all intended volumes are enabled or excluded according to the selected schema.

Written by the indexing model from the issue text.

Description

After some discussions we found scenarios in which we could be interested to enable all the volumes of the detector except one. This is not possible right now.

Right now behaviour is that if we do not specify any active volume, all volumes will be marked as active, and we will register energy deposits at all volumes. If we define 1 or more active volumes then, only those specified volumes will be used to register energy deposits.

We could live with both approaches. But we should check only activeVolume definitions, or only disableVolume definitions are found in storage and apply one schema or the other depending on which keyword we are using.

Dominant language
C++
Stars
2
Forks
4
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rest-for-physics/geant4lib

All issues in rest-for-physics/geant4lib

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.