rescript-lang / rescript-lang/rescript-react
Split into multiple packages?
未关闭
还没有人认领这个 Issue。
- 主要语言
- ReScript
- 星标
- 517
- 派生
- 45
- PR 合并指标
- 30 天内没有已合并 PR
描述
- With JSX4 bringing breaking changes, the JSX3 bindings have been moved into a separate namespace ReactV3. I was wondering if this ReactV3 namespace shouldn't better be provided by some compatibility package.
@rescript/reactcurrently includes bindings for bothreactandreact-domand also has both as peer and dev dependencies. However, not every React project is also using React DOM. E.g. React Native projects aren't. So IMHOreact-dombindings should go into their own package.- #33 mentions the idea to split out ReScriptReactRouter into a separate package.
If we did all that, we'd end up with something like
@rescript/react@rescript/react-dom@rescript/react-jsx3-compat@rescript/rescript-react-router(or justrescript-react-router?)
@mattdamon108 @cristianoc What do you think? How would such a split affect the PPX?
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先审查当前 @rescript/react package 的内容、其 React 和 react-dom bindings 及依赖项,以及 issue 中提到的 PPX 引用。完成标准是就涵盖 ReactV3 兼容性、react-dom 和 ReScriptReactRouter 的 package 拆分达成一致,包括 PPX 将受到怎样的影响。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react
- 领域
- frontend
- Issue 类型
- 重构
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 25/100