rescript-lang / rescript-lang/rescript-react

`suppressHydrationWarning` does not belong to type JsxDOM.domProps

Open
#102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
ReScript
Stars
517
Forks
45
PR merge metrics
No merged PRs in 30d

Description

I am using next-themes lib that requires to add attribute suppressHydrationWarning on the HTML tag.

I think JsxDOM.domProps should be have suppressHydrationWarning type
https://legacy.reactjs.org/docs/dom-elements.html#suppresshydrationwarning

x kevs ws (Code) 2023-09-12 at 12 22 20

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the JsxDOM.domProps type definition and compare its supported attributes with React's suppressHydrationWarning documentation. The work is done when the attribute is accepted on the HTML tag without a type error; no specific test file is mentioned in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.