registrystack / registrystack/registry-stack

BReg change requests: submit admits submitter targets twice, and admission blanks the target context instead of restoring it

Ouverte
#950 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
area:breg criticality:p2 rust triage:needs-implementation
Langage dominant
Rust
Étoiles
2
Forks
0
Merge moyen
2 h 55 min
PR mergées (30 j)
130

Description

Found in the review of PR #929 (2026-09-09). Line references are as of that branch; re-resolve after it merges. Both points are in `crates/registry-breg/src/mutation/request.rs`.

**1. A submit admits its submitter targets twice.** The generic request-action path admits them for Submit and Revise (lines 600-612), and the submit routine admits them again for the same claims (lines 1237-1255). Each call clears the change-request target context, reinstalls the target row boundaries, takes `LOCK TABLE ... IN SHARE MODE` on every target table and re-reads every target row (`admit_submitter_targets`, from line 2201). The second pass is idempotent, so the answer is right; the cost is two rounds of locks and one more place to reason about. Consolidate to one admission per mutation, or state in the code why the submit routine needs its own.

**2. `admit_submitter_targets` clears the target context instead of restoring it.** It sets `registry.change_request_target_context` to the empty string before its loop (lines 2243-2250) and leaves it empty on return. Today that is harmless: admission always runs before any target context is installed, and the coordinator uses the same clear-to-empty as "restore the ordinary request context" (lines 1042-1050). The hazard is latent. An admission that ever runs after `install_change_request_target_context` (`crates/registry-breg/src/postgres/context.rs:2213`) would silently blank a context a later statement depends on, and no test would notice, because clearing is indistinguishable from the ordinary state. Either save and restore the prior value, or assert on entry that the setting is empty so a future reordering fails loudly.

Neither point changes an authorization answer today, which is why they are a follow-up rather than a fix in #929.

Security-sensitive area (change-request admission and the settings the generated RLS policies read); needs explicit review notes when implemented.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez dans crates/registry-breg/src/mutation/request.rs, au niveau du chemin générique Submit/Revise, de la routine de soumission et de admit_submitter_targets ; lisez ensuite la gestion du contexte dans crates/registry-breg/src/postgres/context.rs. Examinez les tests d’admission et de mutation existants, vérifiez que chaque mutation admette les cibles du submitter une seule fois, et confirmez que le contexte de la cible précédente est conservé ou qu’une entrée invalide est rejetée sans modifier les résultats d’autorisation.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
postgresql, rust
Domaine
backend, databases, security
Type d'issue
Refactorisation
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Active
Clarté
Plutôt claire
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.