redhat-developer / redhat-developer/vscode-java
The this keyword causes errors in the "Move Method" refactoring.
Open
Nobody has claimed this yet.
bug
refactoring
upstream
- Dominant language
- TypeScript
- Stars
- 2.3k
- Forks
- 546
- Avg merge
- 20h 1m
- Merged PRs (30d)
- 11
Description
Select the "methodToBeMoved" method, and perform "move" refactoring
Before refactoring
class SourceClass {
TargetClass t;
void methodToBeMoved(SourceClass this) {}
}
class TargetClass{}
After refactoring
class SourceClass {
TargetClass t;
}
class TargetClass{
void methodToBeMoved(SourceClass this) {}
}
Error message: The declared type of the explicit 'this' parameter is expected to be TargetClass
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the VS Code Java extension by selecting methodToBeMoved and running the Move Method refactoring on the supplied Java example. Inspect the Move Method handling for explicit this parameters; done means the refactoring completes without the declared-type error and produces valid Java.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100