redhat-developer / redhat-developer/vscode-java
Better quick fix to "Potential null pointer access": check if the variable is not null
Open
Nobody has claimed this yet.
code action
enhancement
- Dominant language
- TypeScript
- Stars
- 2.3k
- Forks
- 546
- Avg merge
- 20h 1m
- Merged PRs (30d)
- 11
Description
I have the following code:
String s = null;
// do conditional stuff with "s"
s.length() // "Potential null pointer access" warning
Currently VS Code offers me 2 quick fixes:
- "Ignore compiler problem(s)"
- "Add @SuppressWarnings 'null' to myMethod"
A better quick fix option would be to add a "not nulll" check before the method calling.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing quick fixes for the “Potential null pointer access” warning and the two options described in the issue. Determine how a null-check quick fix should behave for the example, then add coverage showing that the new option appears and produces the expected guarded call.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, typescript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100