redhat-developer / redhat-developer/vscode-java

Inline method refactoring leads to syntax errors

Open
#3,597 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

potential-duplicate
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

[provide a description of the issue]

Environment

Operating System: Windows11
JDK version: 17
Visual Studio Code version: 1.88
Java extension version: 1.29

Steps To Reproduce
  1. select "staticMethod()"
  2. click “Refacator-inline method”
  3. class MyClass {

private static int value = 10;
// inline method
public static void staticMethod() {
System.out.println("Value: " + value);
}
}
class AnotherClass {
private int value = 20;
public void callStaticMethod() {
new MyClass().staticMethod();
}
}
refactoring result:
image

Reason: During inline method refactoring, the issue of calling fields was not detected

Expected behavior: Check for grammar issues before and after inline refactoring, and provide warning prompts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the inline method refactoring on Windows 11 with JDK 17, VS Code 1.88, and Java extension 1.29, then trace the inline method refactoring entry point. Done means field calls are detected before or after refactoring and a warning is provided for resulting grammar errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.