redhat-developer / redhat-developer/vscode-java

Refactoring extraction methods leads to naming conflicts

Open
#3,593 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

potential-duplicate
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

[provide a description of the issue]

Environment

Operating System: Windows11
JDK version: 17
Visual Studio Code version: 1.88
Java extension version: 1.29

Steps to Reproduce:

  1. select "extracted();'
  2. click “Refacator-Extract to method”
  3. new method name " extractedMethod() "

class ExtractMethodTest {
public void originalMethod() {};
public void methodA() {
// Extracted method
extracted();
}
private void extracted() {
extractedMethod();
}
private void extractedMethod() {
// TODO Auto-generated method stub
}
public void methodB() {
extracted();
}
}

refactoring result:
image

Reason: When extracting the method, there was no detection of naming conflicts between the new method name and the context

Expected behavior: Check for naming conflicts before and after refactoring, and provide warning prompts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Java “Refactor-Extract to method” flow with the supplied class on the listed Windows 11, JDK 17, and VS Code 1.88 setup, using the Java extension entry point. Trace how the requested extractedMethod name is checked against the surrounding class, then verify that a conflict is detected and a warning is shown before or after refactoring.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.