redhat-developer / redhat-developer/vscode-java

Java support disabled in diff editor for staged files

未关闭
#295 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

enhancement
主要语言
TypeScript
星标
2.3k
派生
546
平均合并
20 小时 1 分钟
30 天内合并 PR
11

描述

See: https://github.com/Microsoft/vscode/issues/34034

It is the case in some other vscode language extensions that one can go to definitions directly from the right hand pane of the diff editor (ie, from the pane that represents the current version of the file). This is great utility when looking at diffs, reviewing changes, etc.

This is currently the case for TS/JS and used to be the case for Go (there was some sort of regression). It would be great if Java supported this.

Environment
  • Operating System: Mac OS X, 10.11.6, Darwin x64 15.6.0
  • JDK version: 1.8.0_92
  • Visual Studio Code version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:12:42.401Z)
  • Java extension version: 0.9.0
Steps To Reproduce
  1. Open a diff editor where one of the panes is the current version of the file, e.g., by going to the source control view and (in the case of git) clicking on one of the diffs for the staged or working tree changes.
  2. Attempt to go to a definition.
Current Result

A message indicating that the definition was not found.

Expected Result

Go to Definition and other tooling (symbols, etc) should work in the pane that represents the current version of the file.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先,在 VS Code 源代码管理视图和差异编辑器中,使用一个 staged 或 working-tree Java 更改重现这些步骤。跟踪 Go to Definition 和符号在 current-version 窗格中的处理方式,然后验证这些工具在那里能够正常工作,且不会出现 definition-not-found 消息。

由索引模型根据 Issue 内容生成。

评估

技术栈
java, vscode
领域
developer-experience, tooling
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。