redhat-developer / redhat-developer/vscode-java

Java support disabled in diff editor for staged files

Open
#295 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

See: https://github.com/Microsoft/vscode/issues/34034

It is the case in some other vscode language extensions that one can go to definitions directly from the right hand pane of the diff editor (ie, from the pane that represents the current version of the file). This is great utility when looking at diffs, reviewing changes, etc.

This is currently the case for TS/JS and used to be the case for Go (there was some sort of regression). It would be great if Java supported this.

Environment
  • Operating System: Mac OS X, 10.11.6, Darwin x64 15.6.0
  • JDK version: 1.8.0_92
  • Visual Studio Code version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:12:42.401Z)
  • Java extension version: 0.9.0
Steps To Reproduce
  1. Open a diff editor where one of the panes is the current version of the file, e.g., by going to the source control view and (in the case of git) clicking on one of the diffs for the staged or working tree changes.
  2. Attempt to go to a definition.
Current Result

A message indicating that the definition was not found.

Expected Result

Go to Definition and other tooling (symbols, etc) should work in the pane that represents the current version of the file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the steps in the VS Code source control view and diff editor with a staged or working-tree Java change. Trace how Go to Definition and symbols are handled in the current-version pane, then verify that these tools work there without the definition-not-found message.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, vscode
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.