redhat-developer / redhat-developer/vscode-java
Installing this extension in codespaces monkey patches fs which can break other extensions.
Personne n'a encore pris cette issue.
- Langage dominant
- TypeScript
- Étoiles
- 2.3k
- Forks
- 546
- Merge moyen
- 20 h 1 min
- PR mergées (30 j)
- 11
Description
Installing both this vscode-java in a codespace breaks the codeql extension.
Environment
- Operating System: codespaces
- JDK version:
- Visual Studio Code version:
- Java extension version:
Steps To Reproduce
- Install both extensions
- Open the codeql pane (load codeql extension)
- Wait for codeql to startup (can take some time due to needing to download
codeqlitself). - In codeql extension choose download a database from lgtm; Pick
g/apache/maven, thenjava. - Open the codeql pane (load codeql extension again)
- Open a java file (load java extension)
- In the workspace root look in the newly added top level root starting
apache_maven_... - An error about accessing
pipesonundefinedhappens.
Additional Informations
This is a very complex 3 way interaction between the 2 extensions and codespaces. The underlying bug is https://github.com/isaacs/node-graceful-fs/issues/170 which is fixed with newer versions of graceful-fs. This is still used by vscode-java so things break I can't quite work out how an old version ends up in vscode-java as the only runtime dependency is optional but specifying --no-optional doesn't fix it (I am not a js/npm expert).
The full issue happens due to the following steps:
- Basically codespaces patches
fs(usinggraceful-fs) so that some values become computed properties. vscode-codeql"subclasses" classes infsdue to (usinggraceful-fs) internally.- The broken version of graceful-fs in
vscode-javais loaded and accidentally mutatesfs(due to the use of computed properties in the patched version offs). - The "classes" in
vscode-codeqldon't have the new prototype in the chain so the new constructors from the broken version offscreate new objects rather than modifyingthis.
Note that the issues with fs having properties is also the case with node 15+ but vscode is on 14 so this will break in future whenever vscode updates nodejs that far.
To fix it you need to ensure the version of graceful-fs is greater than 4.2.2 where the bug is fixed.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par examiner les déclarations de dépendances npm de vscode-java et la manière dont graceful-fs est résolu, puis reproduisez l’interaction entre Codespaces et l’extension CodeQL décrite dans l’issue. Confirmez que la version résolue de graceful-fs est supérieure à 4.2.2 et vérifiez que l’ouverture d’un fichier Java ne provoque plus l’erreur de workspace de la base de données CodeQL.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- node.js, typescript
- Domaine
- devtools, tooling
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100