RequestBodyBufferMiddleware should limit total memory consumption for concurrent requests

Open
#255 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
30/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
php
Domain
api, backend

Research direction

Start by inspecting RequestBodyParserMiddleware and the related discussions in issues #218, #250, and #194. Clarify how concurrent request bodies are buffered and define how a shared total-memory limit should behave; done means concurrent requests cannot exceed that bound while the existing per-request limit remains effective.

Written by the indexing model from the issue text.

Description

new feature

The RequestBodyParserMiddleware currently accepts a limit on the maximum size for a single request (say 100MIB). If you spawn lots and lots of concurrent requests, you can easily take up all available memory. As such, this middleware should probably also take care of limiting total memory consumption for all concurrent requests.

Refs #218
Refs #250
Refs #194

Dominant language
PHP
Stars
781
Forks
166
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reactphp/http

All issues in reactphp/http

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.