reactjs / reactjs/react.dev

ESLint v9 Migration Discussion

未關閉
#8,261 0 則留言 3 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

主要語言
JavaScript
星號
11.8k
分支
7.9k
平均合併
1 天 11 小時
30 天內合併 PR
11

描述

Hi!

I'd like to get your thoughts on migrating to ESLint v9.

Currently, react.dev uses ESLint 7.x, which reached end-of-life in 2024. It's not causing immediate problems, but it's becoming a limitation for adopting new linting tools going forward.

For example, ko.react.dev introduced eslint-markdown to help maintain translation quality in markdown docs. However, these newer plugins only support ESLint 9's flat config. So right now, ko.react.dev is in an awkward situation where it uses ESLint 7 as the base, but has to run npx eslint@9 separately just for markdown linting:

"textlint-lint": "yarn textlint ... && npx --yes eslint@9 -c eslint.config.mjs"

When translation projects try to add more lint rules to improve documentation quality, ESLint 7 becomes a bottleneck. Official ESLint plugins like @eslint/markdown and @eslint/json are all flat config only.

This came up recently in a ko.react.dev discussion (reactjs/ko.react.dev#1406), where a maintainer mentioned:

"If you want CI/CD integration and improvements in this area, please submit an ESLint v9 migration PR to the react.dev repository first, so we can pull it in later."

They also noted that maintaining ESLint 7, ESLint 9, and Textlint together is becoming difficult, and an upstream migration would help simplify things for translation projects.

Also, some dependencies like babel-eslint and eslint-config-react-app are already deprecated and not even being used, so they'll need to be cleaned up at some point anyway.

Of course, this change would also affect other translation repositories, so I understand it needs careful consideration.

What do you think about upgrading to ESLint v9? If you're open to the idea, we might be able to help with the migration work.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

這個 issue 提到了 react.dev 的 ESLint 7.x 設定、ko.react.dev 的 eslint.config.mjs 進入點以及 textlint-lint 指令碼,但沒有提到任何 react.dev 檔案或測試。先找出儲存庫的 ESLint 相依套件和 lint 指令碼,然後在實作之前定義各翻譯儲存庫的移轉範圍和所需的驗證工作。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript
領域
documentation, tooling
Issue 類型
重構
難度
5/5
預估耗時
一週以上
活躍度
停滯
描述清晰度
需要釐清
新手友好度
28/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。