[Typo]: In Sharing State Between Components
Open
Nobody has claimed this yet.
type: typos
- Dominant language
- JavaScript
- Stars
- 11.8k
- Forks
- 7.9k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 11
Description
Summary
When explaining state lifting up, there's a small error in the example function for the second step : Pass hardcoded data from the common parent:
function Panel({ title, children, isActive }) {
return (
<section className="panel">
<h3>{title}</h3>
{isActive ? (
<p>{children}</p>
) : (
<button onClick={() => setIsActive(true)}>
Show
</button>
)}
</section>
);
}
The onClick calls setIsActive, but since there's no state declared, it should be removed.
Page
https://react.dev/learn/sharing-state-between-components
Details
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the Sharing State Between Components page and review the second-step example, “Pass hardcoded data from the common parent.” Remove the onClick call to setIsActive, which has no declared state, and confirm the example no longer references that setter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100