Resetting state docs improvement
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11.8k
- Forks
- 7.9k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 11
Description
Over here: https://react.dev/learn/preserving-and-resetting-state#option-1-rendering-a-component-in-different-positions
about resetting a state, just because a line is drawn to the right, now the Counter becomes a "right" child?
And then, just because the line is drawn to the left, now the Counter becomes a "left" child?
The diagram is:
In reality, it is just "children" nodes. So if you have one child with a line drawn to the left, it doesn't make it a "left" child.
Likewise, if you have one child with a line drawn to the right, it doesn't make it a "right" child.
To some degree, it dumbs down the programmers.
The truth is:
For those three situations in the diagram:
- First child is
Counter, and second child isfalse. (isPlayerA && whateverbecomesfalseifisPlayeris false). There should be a solid line going to afalseas a second child. - First child is
false, and second child isCounter. There should be a solid line going down to the first child which isfalse. - The third case is just like (1).
And then, the rule of React is, the false will not be rendered. But the tree in fact has a false, for the "tree structure" to be "different".
If I am not mistaken, this "tree" is composed, and compared to the previous "tree", for React to decide whether to change something in the actual DOM. This "current" tree and "previous tree", is the idea of Virtual DOM.
So the concepts should be set straight here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the linked “Option 1: Rendering a component in different positions” section and review its diagram and explanation of conditional children. Compare the wording with how React treats false children and positions in the tree. Done means the diagram and text accurately explain the three cases without implying that visual left or right placement defines a child’s identity.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100