Explain index as key can be ok
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 11.8k
- 派生
- 7.9k
- 平均合并
- 1 天 11 小时
- 30 天内合并 PR
- 11
描述
The pitfall warning on https://beta.reactjs.org/learn/rendering-lists states that using index or random for keys is bad. However, this is the only mention of using indexes of keys. I think it should state that using indexes is bad, but it should also be clear that using random values much worse.
The problem is using index as key is a well known anti-pattern in the React world. People come up with much worse solutions, e.g. use a random key, to get rid of ESLint warnings.
Also there are legitimate use cases for an index as a key, for example when rendering a static list of data. I think this should be acknowledged in the Where to get your key section.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
打开 https://beta.reactjs.org/learn/rendering-lists 中的 Rendering Lists 页面,阅读陷阱警告和“Where to get your key”部分。更新说明,使其区分索引 key 和随机 key,并承认静态列表是使用索引 key 的合理情况;当两处的指导都清晰且一致时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, react
- 领域
- documentation
- Issue 类型
- 文档
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 58/100