Signal pattern for identifying events instead of using usePrevious for reacting to events
還沒有人認領這個 Issue。
- 主要語言
- JavaScript
- 星號
- 11.8k
- 分支
- 7.9k
- 平均合併
- 1 天 11 小時
- 30 天內合併 PR
- 11
描述
Not quite sure if this makes sense, so first I wanted to discuss it before creating a PR.
Problem statement since setState does not accept a callback, if we want to execute a code after an async process has been done, we need to use usePrevious to store the old value e.g. updatingRemoteResource = true set just after the async process had started and then compare it with the new value e.g. updatingRemoteResource = false after the async process is done, and then if they are different, we trigger a new event e.g. fetchUpdatedRemoteResource
I described the issue in more detail here:
https://www.reddit.com/r/reactjs/comments/jzqcyu/decoratively_chaining_asynchronous_hooks_for_flow/
and have searched for it for a while, I couldn't find any alternative solutions e.g. after searching for a while I just found this:
e.g. https://stackoverflow.com/questions/53898810/executing-async-code-on-update-of-state-with-react-hooks
Solution I have an idea borrowed from signal processing that could make this much simpler: if there is a state which we need to keep track of from one render to the next, we define it as an array that can form patterns even if it is a primitive i.e. [], [firstValue], [firstValue, secondValue], etc. that can be used to identify different events e.g. [0] updated to [0,1] signalling an on event or [1], [1,0] signalling an off event. More complex events can be formed e.g. for animations, etc. (perhaps it will be even cleaner with observables, but arrays are good enough I suppose)
In its simplest form though, it's actually just an array with a maximum length of one that gets recreated.
e.g. codesandbox
import React, { useEffect, useState } from "react";
// imagine this is in a remote resource e.g. a database
let remoteNumber = 0;
async function updateRemoteNumber() {
return new Promise(function (resolve) {
setTimeout(() => {
remoteNumber = Math.random();
resolve("success");
}, 1000);
});
}
async function fetchRemoteNumber() {
return new Promise(function (resolve) {
setTimeout(() => {
resolve(remoteNumber);
}, 1000);
});
}
export default function App() {
const [updatingNumber, setUpdatingNumber] = useState([0]);
const [fetchingNumber, setFetchingNumber] = useState([0]);
const [reFetchNumber, setRefetchNumber] = useState([0]);
const [number, setNumber] = useState();
async function fetchNumber() {
setFetchingNumber([1]);
setNumber(undefined);
const remoteNumber = await fetchRemoteNumber();
setFetchingNumber([0]);
setNumber(remoteNumber);
}
async function updateNumber() {
setUpdatingNumber([1]);
await updateRemoteNumber();
setUpdatingNumber([1, 0]);
}
useEffect(function initialFetch() {
fetchNumber();
}, []);
useEffect(
function fetchAfterUpdate() {
if (updatingNumber[1] === 0) {
console.log("fetchAfterUpdate");
fetchNumber();
}
},
[updatingNumber]
);
useEffect(
function fetchAfterRefetch() {
if (reFetchNumber[0]) {
console.log("fetchAfterRefetch");
fetchNumber();
}
},
[reFetchNumber]
);
const lastFetchNumber = fetchingNumber[fetchingNumber.length - 1];
const lastUpdatingNumber = updatingNumber[updatingNumber.length - 1];
const loading = lastFetchNumber || lastUpdatingNumber;
return (
<div>
<p>Number: {number >= 0 ? number : "undefined"}</p>
<p>Fetching number: {String(Boolean(lastFetchNumber))}</p>
<p>Updating number: {String(Boolean(lastUpdatingNumber))}</p>
<button
onClick={() => {
setRefetchNumber([1]);
}}
disabled={loading}
>
Re-fetch number
</button>
<button onClick={updateNumber} disabled={loading}>
Update number
</button>
</div>
);
}
Question Is there any issue with this pattern that I am missing, or are there alternative patterns for achieving the same result? Is it non-obvious enough to be added to the docs as a pattern?
Note I should point that this pattern is useful for cases besides async operations as well e.g. imagine implementing a button for a nested set of collapsible items e.g. a tree chart that collapses/expands all the items. This is inherently not a good use case for declarative state management, because although from one render to the next you want all the items to be expanded, you do not want them to remain expanded if you collapse/expand some items afterwards (this can be implemented by passing callbacks as well, but I find this signal pattern much more straightforward).
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從連結的 CodeSandbox 和 issue 中描述的 React Hooks 情境開始;將提議的 signal 模式與問題所詢問的替代模式進行比較。完成的標準是就這是否屬於一個已有文件說明的 React 模式達成 maintainer 核准的決定,並在屬於這種情況時,確定文件的範圍。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript, react
- 領域
- documentation
- Issue 類型
- 文件
- 難度
- 5/5
- 預估耗時
- 一週以上
- 活躍度
- 停滯
- 描述清晰度
- 需要釐清
- 新手友好度
- 25/100