reactjs / reactjs/react.dev

Add proper error description in tutorial

未關閉
#1,867 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

主要語言
JavaScript
星號
11.8k
分支
7.9k
平均合併
1 天 11 小時
30 天內合併 PR
11

描述

URL: https://reactjs.org/tutorial/tutorial.html

In the Lifting State Up we reach a point where we have passed the onClick handler of square from board and we are about to define the handleClick() function and the guide states that for now we will get an error as this.handleClick is not a function
whereas I receive a slightly different error. (enclosed in screenshots)

It would benefit the tutorial to add a screenshot so that the user running through the tutorial is getting the correct type of error.
this might seem excessive but when a person is following a guide step by step even a mention of receiving a planned error seems like a step in the learning and hence we should ensure the user gets a better look at it.
I am just putting this here as maybe a discussion point or if any mod could provide some insight

Screenshot 2019-03-26 at 11 44 58 AM Screenshot 2019-03-26 at 11 45 12 AM

(doesn't seem like a major fix and would love to send a PR for this as well, if we decide to implement this)

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

檢視連結教學 URL 中 React 教學的「Lifting State Up」區段,並將文件中記載的 this.handleClick 錯誤與 issue 中的螢幕截圖進行比較。更新說明或新增要求的螢幕截圖,讓預期的錯誤與使用者遇到的錯誤相符;確認教學從前一個步驟開始仍能正確閱讀。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript, react
領域
documentation
Issue 類型
文件
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。