Better implementation of render props
還沒有人認領這個 Issue。
- 主要語言
- JavaScript
- 星號
- 11.8k
- 分支
- 7.9k
- 平均合併
- 1 天 11 小時
- 30 天內合併 PR
- 11
描述
This page https://reactjs.org/docs/render-props.html introduces the "render props" pattern with a class Mouse. Its implementation is
render() {
return (
<div>
<h1>Move the mouse around! 1</h1>
<Mouse render={mouse => <Cat mouse={mouse} />} />
</div>
);
}
And its usage is
<Mouse render={mouse => <Cat mouse={mouse} />} />
I find that if we implement it as
render() {
const { render: Render } = this.props;
return (
<div
style={{ height: 100, border: "1px solid" }}
onMouseMove={this.handleMouseMove}
>
<Render mouse={this.state} />
</div>
);
}
Then we can allow the following usage patterns:
<Mouse render={({ mouse }) => <Cat mouse={mouse} />} /> // the original Cat class, 1st pattern
<Mouse render={MediumCat} /> // MediumCat is a function component, 2nd pattern
<Mouse render={BigCat} /> // BigCat is a class component, 3rd pattern
With this implementation, we have a pattern (the first one) which is almost the same as the original render props. Also it allows another two usage patterns (actually the 1st and 2nd patterns are the same).
I have created a codesandbox demo. In the demo, MouseTracker1 is the same as documented while MouseTracker2 is different in implementation of Mouse as I suggested.
I wonder if this is a better implementation of "render props". Any thought?
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 issue 中連結的 render-props 頁面及其隨附的 CodeSandbox 示範開始。比較文件中記載的 Mouse 實作與提議的變體;完成的標準是由 maintainer 決定是否應修改文件,並就任何更新的範圍達成共識。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript, react
- 領域
- documentation
- Issue 類型
- 文件
- 難度
- 5/5
- 預估耗時
- 一週以上
- 活躍度
- 停滯
- 描述清晰度
- 需要釐清
- 新手友好度
- 20/100