[iOS][Fabric] RTL horizontal ScrollView: contentOffset prop is not RTL-converted while scrollTo/metrics are, and scrollTo conversion uses stale contentSize
还没有人认领这个 Issue。
- 主要语言
- C++
- 星标
- 127k
- 派生
- 25.3k
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 4
描述
Description
On the New Architecture (Fabric), iOS implements RTL for a horizontal ScrollView by mirroring the view and converting scroll coordinates — but the conversion is asymmetric, and the imperative conversion depends on the native contentSize being current at call time. JS-driven paged lists that work on Paper break on Fabric under RTL.
In React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm (0.81.5; the same code is on main and 0.82-stable):
updateLayoutMetrics:appliesCGAffineTransformMakeScale(-1, 1)to_containerViewand_scrollViewwhenlayoutDirection == RightToLeft._scrollViewMetricsconverts the reported offset:metrics.contentOffset.x = contentSize.width - containerSize.width - contentOffset.x(RTL branch).scrollToOffset:animated:converts the requested offset:offset.x = self.contentSize.width - _scrollView.frame.size.width - offset.x(RTL branch) —main~L1024.updateProps:applies thecontentOffsetprop with no conversion:_scrollView.contentOffset = RCTCGPointFromPoint(newScrollViewProps.contentOffset)—main~L408. TheprepareForRecycle/ state-restore paths setcontentOffsetunconverted too.
Two concrete consequences:
- Prop vs. imperative disagree. In RTL,
contentOffset={{x: k * pageWidth}}positions the view in physical (mirrored) space, whilescrollTo({x: k * pageWidth})positions it in logical space (andonScrollreports logical). For a paged list the prop lands one page off / at the far end relative to an identicalscrollTo. scrollTois timing-dependent. The conversion usesself.contentSize.widthand_scrollView.frame.size.widthat call time. AscrollToissued right after content changes (before the nativecontentSizecommits — e.g. in asetTimeout(0)after a data update, a very common pattern) is converted with stale dimensions and lands on the wrong page. This never happened in LTR (no conversion) and did not happen on Paper, so it surfaces as intermittent, device-only page jumps.
Steps to reproduce
- RTL app:
I18nManager.allowRTL(true); I18nManager.forceRTL(true)and cold launch (the direction is read at startup). newArchEnabled: true, iOS.- Horizontal
ScrollViewwithpagingEnabled, N full-width pages. - Case A — set
contentOffset={{x: k * width}}as a prop; compare the page shown with callingscrollTo({x: k * width, animated: false})after mount: they show different pages. - Case B — change the content (add/remove pages) and in the same tick /
setTimeout(0)callscrollTo({x: k * width}): on a device it frequently lands on a different page thank(converted against the previouscontentSize); readingcontentOffset.xfrom the nextonScrollconfirms the mismatch.
Expected behavior
All offset inputs are converted consistently in RTL — the contentOffset prop (and recycle/state restore) using the same mapping as scrollToOffset: and _scrollViewMetrics — and the imperative conversion should not silently use a stale contentSize (or the behavior should be documented so libraries can wait for the commit).
React Native Version
0.81.5 (Expo SDK 54). Verified the same code paths on main and 0.82-stable.
Affected Platforms
Runtime - iOS (New Architecture / Fabric). Not reproducible on the old architecture; not affected in LTR.
Environment
macOS 15 (Darwin 24.2), Xcode 16.2, iPhone 12 simulator (iOS 18.2) and physical iPhone (iOS 26.3.1), Hermes, newArchEnabled: true.
Real-world impact
react-native-calendars (used widely for RTL calendars) implements its own RTL offset handling for its recyclerlistview-based horizontal pagers; on Fabric that handling — and a naive "just remove the inversion" fix — both fail because of the two points above, producing calendars that jump between days/weeks nonstop. A downstream workaround (keep the pager's container direction: 'ltr' and mirror in JS) will be linked here.
Reproducer
No standalone reproducer repository attached yet; the steps above are minimal and the relevant native lines are cited. Happy to add a reproducer-react-native repo if maintainers want one.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm 开始,比较 updateProps:、prepareForRecycle、状态恢复、scrollToOffset:animated: 和 _scrollViewMetrics。使用列出的 RTL Fabric 复现步骤,观察内容更改前后的 prop offset 和命令式 offset。完成的标准是 RTL offset 输入的行为保持一致,并且内容大小的时序不再导致未记录的页面不匹配,同时相关行为已覆盖或得到清晰记录。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- ios, objective-c
- 领域
- mobile-dev
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 活跃
- 描述清晰度
- 基本清楚
- 新手友好度
- 42/100