react / react/react-native

[iOS][Fabric] Pinch-zoomed ScrollView breaks (position jumps, cannot zoom back out) after its size changes

Offen
#58,499 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Component: ScrollView Needs: Triage :mag: Platform: iOS
Vorherrschende Sprache
C++
Sterne
127k
Forks
25.3k
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
4

Beschreibung

Description

On iOS with the new architecture, a ScrollView with maximumZoomScale > 1 gets into a broken state whenever its size changes while the user is zoomed in (device rotation, or the layout around it changing):

  1. The scrolled position jumps to a different spot.
  2. The content can no longer be zoomed all the way back out; it stays stuck against one side or corner.

The only way to recover is to zoom all the way out in the broken state and then resize again (rotate back and forth). After that it works again until the next resize while zoomed.

Cause. RCTScrollViewComponentView returns _containerView from viewForZoomingInScrollView:, so while zoomed in that view carries UIScrollView's scale transform. In updateState:oldState: a content size change does

_containerView.frame = CGRect{RCTCGPointFromPoint(data.contentBoundingRect.origin), contentSize};
...
self->_scrollView.contentSize = contentSize;
  • Setting frame on a view whose transform is not the identity is undefined behavior per the UIView docs ("If the transform property is not the identity transform, the value of this property is undefined and therefore should be ignored"). In practice UIKit shrinks the container's bounds by the zoom scale, so when the user zooms back out to scale 1 the content is smaller than the scroll view and sits in a corner.
  • contentSize is set to the unzoomed size while zoomScale != 1. UIScrollView itself keeps contentSize at the zoomed size, so the offset is clamped to the wrong range and the position jumps.

The same code is on main today. prepareForRecycle already hints at it: "Invalidate cached content size so that updateState: recalculates the container frame after zoomScale reset (which may have mutated it in RTL)".

Fix: lay the container out through bounds/center and give the scroll view the zoomed content size. PR: https://github.com/react/react-native/pull/58498

Steps to reproduce
  1. Run the reproducer on an iOS device or simulator (new architecture is on by default).
  2. Pinch to zoom in (2x or more) and pan somewhere away from the top-left.
  3. Tap "Resize" (changes the ScrollView's height) or rotate the device.
  4. The position jumps. Pinch back out: the content stays stuck in a corner and does not fill the ScrollView.
  5. Zoom out fully, resize again: it recovers.
React Native Version

0.87.1

Affected Platforms

Runtime - iOS

Output of npx @react-native-community/cli info
Not run: the reproducer repository is a fresh `reproducer-react-native` template pinned to react-native 0.87.1, run on iOS 18 simulator/device.
Stacktrace or Logs
No crash or log output; the bug is visual.
MANDATORY Reproducer

https://github.com/mifi/reproducer-react-native

Screenshots and Videos

None yet.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne mit RCTScrollViewComponentView's updateState:oldState: und prepareForRecycle und führe dann das reproducer-react-native-Beispiel auf iOS aus. Überprüfe das Verhalten beim Zoomen sowie beim Ändern der Größe oder Drehen; fertig ist es, wenn die Scrollposition stabil bleibt und der Inhalt nach den Größenänderungen wieder vollständig herausgezoomt werden kann.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
ios, objective-c, react-native
Bereich
mobile
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
25/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.