react / react/react-native

[Android][0.87.1] numberOfLines crashes when a decorated nested Text range is outside the truncated layout

未关闭
#58,356 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Needs: Triage :mag: Platform: Android
主要语言
C++
星标
127k
派生
25.3k
平均合并
1 天 23 小时
30 天内合并 PR
4

描述

Description

On Android, a Text with numberOfLines can crash the application when a nested Text has textDecorationLine: 'underline' or 'line-through' and the decorated range starts after content that is omitted by the truncated native layout.

Both decoration types fail in the same native drawing path. This is a fatal main-thread exception rather than a redbox or a JavaScript error.

Additional context

drawSpannedDecoration() obtains start and end from the complete Spanned text, then calls layout.getPrimaryHorizontal(start/end). With numberOfLines, the native Layout can end before the decorated span. In this example, the span starts at offset 60 while the only layout line ends at offset 19, so Android throws before drawing the decoration.

Underline and line-through share this drawing function, which explains why both variants crash. A safe fix likely needs to skip or clip decoration ranges to offsets represented by the truncated Layout before calling getPrimaryHorizontal.

Relevant React Native 0.87.1 source:

This may be adjacent to #57900, which reports Android text-decoration rendering differences. This report is specifically about a fatal out-of-bounds exception caused by a decorated range outside a truncated layout.

Steps to reproduce
  1. Clone [react-native-text-decoration-crash-repro](https://github.com/ouabing/react-native-text-decoration-crash-repro).
  2. npm install.
  3. npm start.
  4. npm run android.
  5. Press Reproduce with underline or Reproduce with line-through.

The minimal trigger is:

<Text numberOfLines={1} ellipsizeMode="tail">
  {'Visible first line\n\nThird paragraph\n\nHidden decorated text: '}
  <Text style={{textDecorationLine: 'line-through'}}>
    decorated text outside the one-line layout
  </Text>
</Text>

Changing line-through to underline reproduces the same crash. Removing numberOfLines, the line breaks, or textDecorationLine avoids it.

React Native Version

0.87.1

Affected Platforms

Runtime - Android

Output of npx @react-native-community/cli info
System:
  OS: macOS 26.6.1
  CPU: Apple M1 Pro (arm64)
Binaries:
  Node: 22.13.1
  npm: 10.9.2
  Java: 17.0.16
npmPackages:
  react: 19.2.3
  react-native: 0.87.1
Android:
  Android 14 / API 34 arm64 emulator
  hermesEnabled: true
  newArchEnabled: true
Stacktrace or Logs
FATAL EXCEPTION: main
Process: com.rntextdecorationcrashrepro
java.lang.IndexOutOfBoundsException: offset(60) should be less than line limit(19)
    at android.text.TextLine.measure(TextLine.java:389)
    at android.text.Layout.getHorizontal(Layout.java:1390)
    at android.text.Layout.getHorizontal(Layout.java:1366)
    at android.text.Layout.getPrimaryHorizontal(Layout.java:1336)
    at android.text.Layout.getPrimaryHorizontal(Layout.java:1325)
    at com.facebook.react.views.text.TextDecorationStyleKt.drawSpannedDecoration(TextDecorationStyle.kt:182)
    at com.facebook.react.views.text.internal.span.ReactUnderlineSpan.onDraw(ReactUnderlineSpan.kt:31)
    at com.facebook.react.views.text.ReactTextView.drawTextEffects(ReactTextView.java:283)
    at com.facebook.react.views.text.ReactTextView.onDraw(ReactTextView.java:227)
MANDATORY Reproducer

https://github.com/ouabing/react-native-text-decoration-crash-repro

Screenshots and Videos

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 TextDecorationStyle.kt 开始,尤其检查 getPrimaryHorizontal 调用,然后检查 ReactUnderlineSpan.kt 和 ReactStrikethroughSpan.kt,以追踪两条装饰路径。使用 npm install、npm start 和 npm run android 运行必需的 reproducer,并验证当它们的装饰范围超出截断后的布局时,underline 和 line-through 都不再崩溃。

由索引模型根据 Issue 内容生成。

评估

技术栈
android, kotlin, react-native
领域
mobile
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
描述清楚
新手友好度
75/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。