[iOS] TextInput `autoFocus` called in `didMoveToWindow` causing transition glitches with UIKit
还没有人认领这个 Issue。
- 主要语言
- C++
- 星标
- 127k
- 派生
- 25.3k
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 4
描述
Description
In react-native iOS apps its very common to have a setup where screens are represented as individual UIViewControllers. The most common case is when using:
There is a problem is with transitions between two UIViewController when the new screen contains a <TextInput autoFocus={true} />:
https://github.com/user-attachments/assets/cecca207-bc5f-47d8-a2cc-5e5304592879
There are three issues with the transition:
- (Not very well visible in the video, but) there is a hang before the screen transition starts
- The transition doesn't progress forward all the way. At one point it seems like its slightly reset back, before moving forward again
- The keyboard changes its color weirdly from dark to light (i also noticed that's not visible in the video, you can see on the second video below)
Now, your first reaction might be that this is a bug with react-native-screens. It's not, let me explain.
The "problem" is that react-native TextInput implementation calls becomeFirstResponder in didMoveToWindow:
If you try the same in a native iOS app, you can reproduce the issue! I created a sample native iOS app and tried this (the second transition in the recording is actually fine, so this is a bit of a race condition thing it seems):
https://github.com/user-attachments/assets/a621d2b8-2242-409f-b2bf-5c5144ed08d9
It seems like this was added back in 2019/2020 to react-native, and back then it seemed to be the correct way to handle the transition correctly (ironically without that code it was causing the same issue i am reporting now)
- https://github.com/facebook/react-native/pull/27217
- https://github.com/facebook/react-native/pull/27803
And it seems like this was working fine, until iOS 16 came out. Since then new issue reports appeared on react-native-screens about this:
And in that sense, this seems to me a bit also like an iOS regression. Now, is this a bug we should just delegate to apple to fix in iOS?
I was contemplating about that, and I think it would be good to raise the issue, but at the same time it seems like its not 100% apple's fault.
After some research and talking to some iOS developers they all told me that you'd usually request focus for an input in viewDidAppear, not in didMoveToWindow. In didMoveToWindow we don't know if there is a transition is still in progress, where viewDidAppear seems to be the place we can be absolutely sure our view is present, and the VC fully appeared.
This does change the style of the transition a bit, as you will see the screen transition finish and only then the keyboard appears [but as a pay off it's never buggy]:
https://github.com/user-attachments/assets/2f2c53ce-87d8-4e8c-8f3d-427384ef4ee3
I checked all native iOS apps on my phone, including some of apple's, and it seems like all open the keyboard after the VC transition finished. I vaguely recall that when iOS 16 came out people were complaining that apple "broke the keyboard".
I will open the discussion on how we may want to address in the comments below.
Steps to reproduce
- Clone the reproducer
- Run it, click the button
React Native Version
0.85.2
Affected Platforms
Runtime - iOS
Output of npx @react-native-community/cli info
info Fetching system and libraries information...
System:
OS: macOS 26.4.1
CPU: (16) arm64 Apple M4 Max
Memory: 117.55 MB / 48.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 22.14.0
path: /nix/store/04fc23dsflkxl4s9p6lkigia1hq3vjp2-nodejs-22.14.0/bin/node
Yarn:
version: 1.22.22
path: /Users/hannogoedecke/.yarn/bin/yarn
npm:
version: 10.9.2
path: /nix/store/04fc23dsflkxl4s9p6lkigia1hq3vjp2-nodejs-22.14.0/bin/npm
Watchman:
version: 2024.03.11.00
path: /Users/hannogoedecke/.nix-profile/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /Users/hannogoedecke/.nix-profile/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 25.2
- iOS 26.2
- macOS 26.2
- tvOS 26.2
- visionOS 26.2
- watchOS 26.2
Android SDK: Not Found
IDEs:
Android Studio: 2025.3 AI-253.30387.90.2532.14935130
Xcode:
version: 26.2/17C52
path: /usr/bin/xcodebuild
Languages:
Java: Not Found
Ruby:
version: 3.4.2
path: /Users/hannogoedecke/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli":
installed: 20.1.0
wanted: 20.1.0
react:
installed: 19.2.3
wanted: 19.2.3
react-native:
installed: 0.85.2
wanted: 0.85.2
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
Stacktrace or Logs
No logs are relevant for this issue
MANDATORY Reproducer
https://github.com/hannojg/ios-textinput-autofocus-transition-uikit-issues
Screenshots and Videos
No response
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm 开始,重点查看 didMoveToWindow 的实现,并运行必需的 iOS reproducer 来观察转换过程。比较链接的历史 pull request,并确定一致认可的 focus 时序行为;当转换和键盘显示稳定且不会使 autoFocus 发生回归时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- ios, objective-c, react-native
- 领域
- mobile
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100