react / react/react-native

[Android, Accessibility] Modals break when pressing ESC on physical keyboard

Aperta
#56,411 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

API: Keyboard Component: Modal Needs: Triage :mag: Platform: Android
Lingua principale
C++
Stelle
127k
Fork
25.3k
Merge medio
1g 23h
PR unite (30g)
4

Descrizione

Description

When closing a Modal with ESC key from a Bluetooth keyboard on Android,
the modal closes natively but onRequestClose callback is not invoked.
This leaves React state out of sync.

Steps to reproduce
  1. Run the reproducer on Android device with Bluetooth keyboard connected
  2. Press "Open Modal" button
  3. Press hardware BACK button or use the BACK gesture -> "onRequestClose called!" alert appears ✅
  4. Press "Open Modal" again
  5. Press ESC key -> Modal closes but NO alert appears ❌
  6. Modal state is still 'true' in React but Modal is closed
  7. Press "Open Modal" again -> Nothing happens (state is already true)

BEWARE: after the state gets stuck you cannot tap on the screen anymore, you have to reach and activate the reset state button via keyboard.

EXPECTED: ESC should call onRequestClose (like back button does)
ACTUAL: Modal closes silently without calling any callbacks

React Native Version

0.84.1

Affected Platforms

Runtime - Android

Output of npx @react-native-community/cli info
System:
  OS: macOS 26.4
  CPU: (8) arm64 Apple M2
  Memory: 116.42 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 24.14.1
    path: /Users/XXX/.nvm/versions/node/v24.14.1/bin/node
  Yarn:
    version: 1.22.22
    path: /opt/homebrew/bin/yarn
  npm:
    version: 11.11.0
    path: /Users/XXX/.nvm/versions/node/v24.14.1/bin/npm
  Watchman:
    version: 2022.11.28.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/XXX/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 25.2
      - iOS 26.2
      - macOS 26.2
      - tvOS 26.2
      - visionOS 26.2
      - watchOS 26.2
  Android SDK:
    API Levels:
      - "34"
      - "35"
      - "36"
    Build Tools:
      - 33.0.1
      - 34.0.0
      - 35.0.0
      - 36.0.0
    Android NDK: Not Found
IDEs:
  Android Studio: 2025.2 AI-252.25557.131.2521.14344949
  Xcode:
    version: 26.2/17C52
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.16
    path: /usr/bin/javac
  Ruby:
    version: 2.7.5
    path: /Users/XXX/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 20.1.3
    wanted: ^20.1.3
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.84.1
    wanted: 0.84.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true
Stacktrace or Logs
-
MANDATORY Reproducer

https://snack.expo.dev/@andreamartinez/react-native-modal-esc-key-bug

Screenshots and Videos

In the video the first modal closing is operated via Back gesture. When you see the blue outline on the buttons I am using the keyboard.

https://github.com/user-attachments/assets/aff72723-bc86-4f40-8c6e-cdcd86bd125d

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia con il riproduttore Snack collegato e la gestione di Android Modal, confrontando il percorso del tasto Indietro hardware con la gestione del tasto ESC. Verifica che la pressione di ESC invochi onRequestClose e mantenga sincronizzato lo stato del modal React, quindi verifica lo stesso comportamento su un dispositivo Android con una tastiera Bluetooth.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
android, react-native
Ambito
accessibility, mobile
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.