Codegen variable naming can result in incorrect code
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- C++
- Estrellas
- 127k
- Forks
- 25.3k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 4
Descripción
Description
type MyEventType = {
type: string;
payload: {
message: string;
}
};
export interface NativeProps extends ViewProps {
onPressed?: CodegenTypes.BubblingEventHandler<MyEventType> | null;
}
codegen generates such a code not the payload variable gets shadowed. And the bug is in the line: payload.setProperty(runtime, "payload", payload);
void SimpleViewEventEmitter::onPressed(OnPressed event) const {
dispatchEvent("pressed", [event=std::move(event)](jsi::Runtime &runtime) {
auto payload = jsi::Object(runtime);
payload.setProperty(runtime, "type", event.type);
{
auto payload = jsi::Object(runtime);
payload.setProperty(runtime, "message", event.payload.message);
payload.setProperty(runtime, "payload", payload);
}
return payload;
});
}
See
https://github.com/mfazekas/codegen-variable-naming-bug
Steps to reproduce
check out https://github.com/mfazekas/codegen-variable-naming-bug
cd ReproducerApp/ios
pod install
cat build/generated/ios/react/renderer/components/AppSpec/EventEmitters.cpp
React Native Version
0.81.4
Affected Platforms
Other (please specify)
Areas
Codegen
Output of npx @react-native-community/cli info
info Fetching system and libraries information...
System:
OS: macOS 15.6
CPU: (12) arm64 Apple M2 Max
Memory: 125.66 MB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 22.16.0
path: ~/.nvm/versions/node/v22.16.0/bin/node
Yarn:
version: 1.22.21
path: ~/.local/bin/yarn
npm:
version: 11.5.2
path: ~/.nvm/versions/node/v22.16.0/bin/npm
Watchman:
version: 2025.06.30.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /Users/boga/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.5
- iOS 18.5
- macOS 15.5
- tvOS 18.5
- visionOS 2.5
- watchOS 11.5
Android SDK: Not Found
IDEs:
Android Studio: 2025.1 AI-251.26094.121.2513.14007798
Xcode:
version: 16.4/16F6
path: /usr/bin/xcodebuild
Languages:
Java:
version: 20.0.1
path: /usr/bin/javac
Ruby:
version: 2.7.8
path: /Users/boga/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
Stacktrace or Logs
n/a
MANDATORY Reproducer
https://github.com/mfazekas/codegen-variable-naming-bug
Screenshots and Videos
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con el reproductor obligatorio, ejecuta pod install en ReproducerApp/ios e inspecciona build/generated/ios/react/renderer/components/AppSpec/EventEmitters.cpp. Sigue la nomenclatura de la payload de evento generada a partir del ejemplo de TypeScript; está terminado cuando el C++ generado ya no oculta la payload externa y conserva los datos del evento anidado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- cpp, react-native, typescript
- Área
- mobile-dev, tooling
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Activo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 68/100