react / react/react-native

AppState 'change' fires redundant 'active' when app is already active the first time the listener is added on Android iOS Prod

Abierto
#45,418 3 comentarios 10 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

API: AppState Issue: Author Provided Repro Platform: Android
Lenguaje dominante
C++
Estrellas
127k
Forks
25.3k
Merge medio
1 d 23 h
PR fusionados (30 d)
4

Descripción

Description

On Android and iOS PROD when the AppState listener 'change' is added the very first time it automatically also fires the listener with nextState as "active" even though the app is already "active".

This issue occurs specifically on Prod and not Dev. On Dev it works as expected where the listener is not fired the first time it's added. listener is only fired the first time when the app goes to the background.

EXPECTED BEHAVIOR:
The behavior should be the same with dev and prod where the listener does not automatically fire with 'active' when it's added the very first time.

Steps to reproduce
  1. Create a new RN app with npx react-native init androidAppStateIssue
  2. Add the AppState 'change' listener on a button click as follows
  const addAppStateListener = () => {
    // read 'AppState.currentState' to register current state on prod
    // comment, uncomment this console.log to see difference on prod
    console.log('INITIAL', AppState.currentState);

    AppState.addEventListener('change', nextAppState => {
      console.log('nextAppState', nextAppState);
    });
  };

return (
...
<Button title="addAppStateListener" onPress={addAppStateListener} />
)
  1. Build on Android/iOS, generate apk/app and install on emulator/simulator (PROD).
  2. Click the addAppStateListener button and notice that the listener is NOT automatically fired with "active" when the listener is added.
  3. Comment the line console.log('INITIAL', AppState.currentState); and rebuild, re-install app.
  4. Click the addAppStateListener button and notice that the listener IS automatically fired with "active" when the listener is added
React Native Version

0.74.3 (current latest)

Affected Platforms

Other (please specify)
Android and iOS PROD

Output of npx react-native info
System:
  OS: macOS 14.5
  CPU: (10) arm64 Apple M1 Pro
  Memory: 89.75 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.20.4
    path: ~/.nvm/versions/node/v18.20.4/bin/node
  Yarn:
    version: 1.22.22
    path: ~/.nvm/versions/node/v18.20.4/bin/yarn
  npm:
    version: 10.7.0
    path: ~/.nvm/versions/node/v18.20.4/bin/npm
  Watchman:
    version: 2023.12.04.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.12.1
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK:
    API Levels:
      - "33"
      - "34"
    Build Tools:
      - 30.0.3
      - 33.0.0
      - 33.0.1
      - 34.0.0
    System Images:
      - android-33 | Google APIs ARM 64 v8a
      - android-34 | Google APIs ARM 64 v8a
      - android-35 | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10671973
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.9
    path: /Users/ashwsrir/.jenv/shims/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.3
    wanted: 0.74.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false
Stacktrace or Logs

When listener is added for the first time in dev vs prod. (make sure to comment the console.log('INITIAL', AppState.currentState)on app)

dev

Running "androidAppStateIssue
listener is added

prod

Running "androidAppStateIssue
listener is added
nextAppState', 'active' <== additional event fired
Reproducer

https://github.com/ashwinkumar6/androidAppStateIssue

Screenshots and Videos

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con el comportamiento de AppState.addEventListener y AppState.currentState en la implementación de React Native 0.74.3 y, después, reproduce el problema usando el ejemplo androidAppStateIssue enlazado, tanto en builds de desarrollo como de producción. Rastrea el primer registro del listener en Android e iOS y verifica que añadirlo no emita un evento active innecesario cuando la app ya está activa.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
android, ios, javascript, react-native
Área
mobile
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.