Unmounting list header component while applying maintainVisibleContentPosition to flatlist renders white space in place of header compoent on Ios
未关闭
还没有人认领这个 Issue。
Component: FlatList
Issue: Author Provided Repro
Needs: Triage :mag:
Platform: iOS
- 主要语言
- C++
- 星标
- 127k
- 派生
- 25.3k
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 4
描述
Description
If a flatlist with a maintainVisibleContentPosition prop set has a header list component that is unmounted then the header component unmounts but the list does not scroll to the first element and instead renders white space.
Here is the source code also available as snack:
import React, {useState} from 'react';
import {
SafeAreaView,
View,
FlatList,
StyleSheet,
Text,
StatusBar,
Button,
} from 'react-native';
type ItemProps = {title: string};
const Item = ({title}: ItemProps) => (
<View style={styles.item}>
<Text style={styles.title}>{title}</Text>
</View>
);
const App = () => {
const [isHeaderShown, setIsHeaderShown] = useState(true);
return (
<SafeAreaView style={styles.container}>
<FlatList
maintainVisibleContentPosition={{
minIndexForVisible: 0,
autoscrollToTopThreshold: 0,
}}
ListHeaderComponent={
isHeaderShown ? (
<View style={{padding: 128, backgroundColor: 'red'}} />
) : null
}
data={Array.from({length: 30})
.fill(0)
.map((_, index) => `Item ${index}`)}
renderItem={({item}) => <Item title={item} />}
/>
<Button
title="press me"
onPress={() => {
setIsHeaderShown(prev => !prev);
}}
/>
</SafeAreaView>
);
};
const styles = StyleSheet.create({
container: {
flex: 1,
marginTop: StatusBar.currentHeight || 0,
},
item: {
backgroundColor: '#f9c2ff',
padding: 20,
marginVertical: 8,
marginHorizontal: 16,
},
title: {
fontSize: 32,
},
});
export default App;
Steps to reproduce
- click on the
press mebutton and notice how there is white space on ios and the list does not scroll, but works fine on android
React Native Version
0.73.4
Affected Platforms
Runtime - iOS
Output of npx react-native info
System:
OS: macOS 14.1.2
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 2.57 GB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.17.1
path: ~/.nvm/versions/node/v18.17.1/bin/node
Yarn:
version: 1.22.19
path: ~/.nvm/versions/node/v18.17.1/bin/yarn
npm:
version: 9.6.7
path: ~/.nvm/versions/node/v18.17.1/bin/npm
Watchman:
version: 2024.01.22.00
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.15.0
path: /Users/ramiel/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.2
- iOS 17.2
- macOS 14.2
- tvOS 17.2
- visionOS 1.0
- watchOS 10.2
Android SDK: Not Found
IDEs:
Android Studio: 2023.1 AI-231.9392.1.2311.11076708
Xcode:
version: 15.2/15C500b
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.15
path: /usr/local/opt/openjdk@11/bin/javac
Ruby:
version: 2.7.6
path: /Users/ramiel/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.73.4
wanted: 0.73.4
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
### Stacktrace or Logs
```text
No Stacktrace or Logs
Reproducer
https://snack.expo.dev/@ramiel99/maintainvisiblecontentposition-header-top
Screenshots and Videos
https://github.com/facebook/react-native/assets/80689446/c563b30a-b61d-4822-9e77-0820b25756a7
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从链接的 Snack 复现示例以及 iOS 上 FlatList maintainVisibleContentPosition 的行为开始。跟踪 iOS 对有条件卸载的 ListHeaderComponent 的处理,然后验证切换 header 会移除空白区域并滚动到第一项,同时不会导致 Android 行为回归。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- ios, react-native
- 领域
- mobile
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100