Text renders 1px bigger than View when explicitly given the same height with a specific combination of height and pixel ratio.
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- C++
- Estrellas
- 127k
- Forks
- 25.3k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 4
Descripción
Description
Explicitly setting height: 15 on a parent View and child Text on a device with a pixel ratio of 3.5 (Pixel 7 Pro emulator) causes the child Text to render 1 px bigger than the parent View due to rounding in Yoga. When the Text is given a small border (borderWidth: 0.5) the bottom of the border is clipped by the parent View. This only happens with a certain offset from top - achieved for example by setting marginTop: 295.
There are several values and combinations of height and pixelRatio that give this result. I've only observed this on Fabric, on old architecture it renders the same.
Steps to reproduce
- Enable new architecture
- Use the following code:
const print_height = (layout: LayoutRectangle, component: string) => {
const {height} = layout;
console.log(`${component}'s height = ${height}`);
};
const TestApp = () => {
return (
<View
style={styles.View}
onLayout={event => print_height(event.nativeEvent.layout, 'View')}>
<Text
style={styles.Text}
onLayout={event => print_height(event.nativeEvent.layout, 'Text')}>
kkkkkkkk
</Text>
</View>
);
};
const styles = StyleSheet.create({
View: {
justifyContent: 'center',
alignItems: 'center',
overflow: 'hidden',
height: 15,
marginTop: 295,
},
Text: {
fontSize: 8,
overflow: 'hidden',
height: 15,
borderWidth: 0.5,
borderRadius: 4,
},
});
- Run on a device/emulator with
pixelRatio: 3.5(ex. Pixel 7 Pro)
React Native Version
0.73.1
Affected Platforms
Runtime - Android
Areas
Fabric - The New Renderer
Output of npx react-native info
System:
OS: macOS 13.5.2
CPU: (8) arm64 Apple M1 Pro
Memory: 100.84 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.8.0
path: /opt/homebrew/bin/node
Yarn:
version: 1.22.21
path: /opt/homebrew/bin/yarn
npm:
version: 10.1.0
path: /opt/homebrew/bin/npm
Watchman:
version: 2023.09.25.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods: Not Found
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.2
- iOS 17.2
- macOS 14.2
- tvOS 17.2
- watchOS 10.2
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10406996
Xcode:
version: 15.1/15C65
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.6
path: /usr/bin/javac
Ruby:
version: 3.2.2
path: /opt/homebrew/opt/ruby/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.73.1
wanted: 0.73.1
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: Not found
newArchEnabled: false
Stacktrace or Logs
n\a
Reproducer
https://github.com/zglapa/reproducer_view_text_size
Screenshots and Videos
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
El issue no menciona archivos ni pruebas del repositorio. Empieza ejecutando el reproducer enlazado con Fabric habilitado en un dispositivo o emulador Android usando una proporción de píxeles de 3.5; después, sigue el comportamiento del redondeo del layout en la ruta de Fabric/Yoga. Se considera terminado cuando las alturas explícitamente iguales de View y Text siguen siendo iguales y el borde de medio píxel no se recorta en la reproducción indicada.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- android, react
- Área
- mobile-dev
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100