react / react/react-native

[TextInput] lineheight cuts off content on iOS

未关闭
#41,240 9 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Component: TextInput Issue: Author Provided Repro Newer Patch Available Platform: iOS
主要语言
C++
星标
127k
派生
25.3k
平均合并
1 天 23 小时
30 天内合并 PR
4

描述

Description

The TextInput on iOS cuts off content at dashes (-) if it has the lineHeight style applied to it. This happens when content is to long and therefore isn't completely visible in the input without moving through it.

If the lineHeight isn't applied it is not cut off at the dash (-) and the content will end with ellipsis (...).

We tried removing everything from the input and found out in that way it was the lineHeight that causes this issue.

This only happens on iOS and not on Android.

React Native Version

0.71.13

Output of npx react-native info
System:
    OS: macOS 14.0
    CPU: (10) arm64 Apple M1 Pro
    Memory: 55.56 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm
    Watchman: 2023.10.02.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.13.0 - /Users/thomaslamars/.rvm/gems/ruby-2.7.5/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 23.0, iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 2022.2 AI-222.4459.24.2221.9971841
    Xcode: 15.0.1/15A507 - /usr/bin/xcodebuild
  Languages:
    Java: 18.0.2.1 - /Library/Java/JavaVirtualMachines/jdk-18.0.2.1.jdk/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0 
    react-native: ^0.71.13 => 0.71.13 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found
Steps to reproduce

It is reproducible by making an TextInput with just lineHeight on it with the styling.
Than as value pass a really long string or type a really long string with dashes.
Get out of focus with the input and see that the value in the input gets truncated.

import { TextInput, SafeAreaView, StyleSheet } from 'react-native';

export default function App() {
  const value = "Thisisareallylong emailwithdashes-init@thawdisisasnackwhichisanexample.com"

  return (
    <SafeAreaView style={styles.container}>
      <TextInput value={value} style={{ lineHeight: 20 }} />
    </SafeAreaView>
  );
}
Snack, screenshot, or link to a repository
Snack url

Reproducible on Snack with expo 49 and react native version 0.72.4
https://snack.expo.dev/l0o3kNldL

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先使用由长破折号组成的值运行链接的 Snack 复现,并比较有无 lineHeight 时 iOS TextInput 的行为。然后追踪负责渲染和截断的 iOS TextInput 入口点,并验证长内容不再在破折号处被截断,同时 Android 的行为保持不变。

由索引模型根据 Issue 内容生成。

评估

技术栈
ios, react-native
领域
mobile
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。