react / react/react-native

Cannot use DynamicColorIOS or PlatformColor with Share tintColor option

未关闭
#30,396 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

API: Share Needs: Repro Needs: Triage :mag: Never gets stale Platform: iOS
主要语言
C++
星标
127k
派生
25.3k
平均合并
1 天 23 小时
30 天内合并 PR
4

描述

Description

Following up with my previous issue regarding the new PlatformColor and DynamicColorIOS APIs. I like this quest!

I've encountered another issue, this time when using these new color APIs with the Share API. Anytime I try to use either a PlatformColor or DynamicColorIOS as the tint color I get the following error:

[Fri Nov 13 2020 19:51:50.612]  WARN     Possible Unhandled Promise Rejection (id: 3):
Invariant Violation: Unexpected color given for options.tintColor

React Native version:

System:
    OS: macOS 11.0.1
    CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
    Memory: 20.24 MB / 20.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.3.0 - /var/folders/n8/l8xdjt192lb9lpfrkyh9v57m0000gn/T/yarn--1605466607306-0.2082520059346018/node
    Yarn: 1.22.5 - /var/folders/n8/l8xdjt192lb9lpfrkyh9v57m0000gn/T/yarn--1605466607306-0.2082520059346018/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v14.3.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.0 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.2, DriverKit 20.0, macOS 11.0, tvOS 14.2, watchOS 7.1
    Android SDK:
      API Levels: 28, 29
      Build Tools: 28.0.3, 29.0.2
      System Images: android-28 | Intel x86 Atom_64
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.6953283
    Xcode: 12.2/12B45b - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_272 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1 
    react-native: 0.63.3 => 0.63.3 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

  1. Use a PlatformColor or DynamicColorIOS to set the tint color option for the Share API
  2. Call the share API
  3. No share sheet appearing and error in the logs

Expected Results

Share sheet should appear without errors

Snack, code example, screenshot, or link to a repository:

import { PlatformColor, Share } from 'react-native'

const shareWithPlatformColor = () => Share.share('This is a nice content to share', {
  tintColor: PlatformColor('systemYellow'),
})

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 React Native Share API 入口开始,使用提供的 PlatformColor 示例在 iOS 上复现该问题。跟踪生成“Unexpected color given for options.tintColor.”的 tintColor 验证逻辑。当 tintColor 使用 PlatformColor 或 DynamicColorIOS 时,分享面板能够无错误地显示,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
ios, javascript, react
领域
api, mobile
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。