Memory leak when programmatically changing 'source' prop of Image
未关闭
还没有人认领这个 Issue。
Bug
Component: Image
Good first issue
Platform: iOS
- 主要语言
- C++
- 星标
- 127k
- 派生
- 25.3k
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 4
描述
Description
If you use an Image component in render and use the parent component's state to manage the source prop, each time the source is changed the previous source is not deallocated. Even when the parent component is unmounted, the previous images still use memory.
Reproduction
I've made a simple ImageTest project that demonstrates the bug. (IMPORTANT: run app in release mode to experience the issue)
Code:
/**
* Sample React Native App
* https://github.com/facebook/react-native
* @flow
*/
import React, { Component } from 'react';
import {
AppRegistry,
StyleSheet,
Text,
View,
Image,
TouchableHighlight,
Dimensions,
} from 'react-native';
import image0 from './images/0.png'
import image1 from './images/1.png'
import image2 from './images/2.png'
import image3 from './images/3.png'
import image4 from './images/4.png'
const images = [
image0,
image1,
image2,
image3,
image4,
]
export default class ImageTest extends Component {
constructor() {
super()
this.state = ({
counter: 0,
})
}
increment = () => {
this.setState({
counter: this.state.counter + 1
})
}
render() {
const imageSource = images[this.state.counter]
return (
<View>
<Image
source={imageSource}
style={styles.image}
/>
<TouchableHighlight onPress={this.increment} style={styles.highlight}>
<Text style={styles.text}>NEXT IMAGE</Text>
</TouchableHighlight>
</View>
);
}
}
const window = Dimensions.get('window')
const styles = StyleSheet.create({
highlight: {
backgroundColor: 'yellow',
position: 'absolute',
bottom: 0,
left: 0,
},
text: {
fontSize: 50,
},
image: {
width: window.width,
height: window.height,
},
});
AppRegistry.registerComponent('ImageTest', () => ImageTest);
Solution
Presumably when the source is changed the underlying UIImage/UIImageView needs to be destroyed.
Additional Information
- React Native version: 0.41.0
- Platform: iOS
- Operating System: MacOS 10.12.3 / xcode 8.2
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从链接的 ImageTest 复现开始,并在 iOS release mode 下运行它,在观察内存的同时更改 Image component 的 source prop。跟踪 Image component 对 source 更改的 native iOS 处理;完成标准是更改后以及 parent component 卸载后,之前的图像都会被释放。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- ios, react-native
- 领域
- mobile
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100