react-navigation / react-navigation/react-navigation.github.io

Linking inconsistency between closed app and open app deep link

Open
#891 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
324
Forks
2k
PR merge metrics
No merged PRs in 30d

Description

When I do the following deeplink myApp://detail/123 (123 being an ID) with the app being closed and the following config

screens: {
  detail: {
    path: 'detail/:id',
  },
},

I'll get the correct state

{"key": "detail-SbcExuYkpp6-Y4u9rYWjO", "name": "detail", "params": {"id": "123"}}

but if the app is already open (foreground or background), and I send another deeplink, then this is the state I get

{"key": "detail-vqAsOQ3ZBfydQjUCcpX9e", "name": "detail", "params": {"initial": false, "params": {"id": "123"}, "screen": "detail", "state": undefined}}

So for some reason, you get a nested params

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the myApp://detail/123 deeplink with the app closed and then foregrounded or backgrounded, using the shown detail/:id configuration. Compare the resulting navigation states and identify why the open-app case nests params; done means both launch states produce the same parameter structure.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.