react-component / react-component/trigger
Updating the React version
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 391
- Forks
- 245
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
are there any plans for updating the react version from 16.0 to 16.4?
We are using React.StrictMode and we encounter the following warning in the console:
"""
index.js:1427 Warning: Unsafe lifecycle methods were found within a strict-mode tree:
in div (created by MyReactComponent)
in MyReactComponent (created by component)
in div (created by component)
in component (created by RouterContext)
in RouterContext (created by Router)
in Router
componentWillMount: Please update the following components to use componentDidMount instead: Trigger
componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Trigger
Learn more about this warning here:
https://fb.me/react-strict-mode-warnings
"""
I know it's probably a lot a work to go around the code base and update all the older and now unsafe life-cycle methods, but I am just wondering if you have any plans on an update.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the React 16.0 dependency and the Trigger component referenced in the React.StrictMode warning. Review the affected lifecycle methods and project tests to determine the scope of a React 16.4 update; done means the dependency is updated and the reported strict-mode warnings are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100