Make machine_id result consistant across Meterpreters

Open
#5,441 8 comments 0 reactions 1 assignee View on GitHub

@bcook-r7 is already working on this.

Since Jun 7, 2015.

Assessment

This issue has not been assessed yet.

Description

bug meterpreter not-stale

At the moment the PHP Meterpreter returns a different value for machine_id as per this comment. The machine_id code on posix should do one of the following:

  • Sort the list of entries in /dev/disk/by-id/ before selecting the first one.
  • Have some other way of making sure that the chosen entry from /dev/disk/by-id/ is consistent.
  • Use a completely different way of getting something unique off the machine that works consistently in each Meterpreter that runs on POSIX.

I'm open to suggestions!

Dominant language
Ruby
Stars
39k
Forks
15k
Avg merge
5d 6h
Merged PRs (30d)
32

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rapid7/metasploit-framework

All issues in rapid7/metasploit-framework

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.