Avoid logging `Session cookie encryptor error: ...` by default?
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start in lib/rack/session/cookie.rb around lines 223-224 and compare the $VERBOSE handling in lib/rack/session/abstract/id.rb around line 397. The issue leaves open whether errors should be silent by default or controlled by an opt-in setting. Done means the chosen logging behavior is implemented for the listed encryptor error variants.
Written by the indexing model from the issue text.
Description
Does it makes sense to be able to silence this logging or make it opt-in?
Maybe behind $VERBOSE as done here?
Looks like it can log the following variants of Session cookie encryptor error: <message>
wrong versionMessage is invalidinvalid messageHMAC is invalid
I'm not sure they're useful to always have enabled (in production) as any user can trigger at least Session cookie encryptor error: Message is invalid by sending bogus data in the Cookie header.
- Dominant language
- Ruby
- Stars
- 52
- Forks
- 22
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rack/rack-session
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
rack/rack-session#52 · 5 comments · 1 reaction ·
-
Unused test code Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
rack/rack-session#51 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
rack/rack-session#40 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
rack/rack-session#35 · 1 comment · 1 reaction ·
All issues in rack/rack-session
Similar issues
-
バグ
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
voxpupuli/puppet-epel#186 · 1 comment ·
-
external_created_at is no longer used for the message timestamp since the new message UI (v4.4.0) OpenBug Frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
TheOdinProject/curriculum#31402 · 1 comment ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100