Hide "Loading metadata database" progress bar using `pkg.show_progress` option

Open
#95 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
r
Domain
cli

Research direction

Inspect R/metadata-cache.R lines 607-615 and compare them with the progress handling in R/progress-bar.R line 7. Confirm how pkg.show_progress is used elsewhere, then ensure the “Loading metadata database” progress bar follows that option. Done means the bar can be enabled or disabled consistently with the other progress bars.

Written by the indexing model from the issue text.

Description

feature

Even if it's not documented - many packages make use of pkg.show_progress option to enable/disable progress bars. This package is no exception and it is used e.g. here:
https://github.com/r-lib/pkgcache/blob/42e824939482c87b6216dfe30b7542a6e2e06d0f/R/progress-bar.R#L7

But unfortunately not everywhere and there is one little guy that still does not use it:
https://github.com/r-lib/pkgcache/blob/42e824939482c87b6216dfe30b7542a6e2e06d0f/R/metadata-cache.R#L607-L615

Dominant language
R
Stars
30
Forks
19
Avg merge
4d 19h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from r-lib/pkgcache

All issues in r-lib/pkgcache

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.