Present tense / past tense mixing
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start by running the provided reprex with lifecycle::deprecate_warn() and compare the two warning messages. Trace the implementation behind that entry point, then make the tense consistent and verify that both function and argument deprecation warnings use the agreed wording.
Written by the indexing model from the issue text.
Description
Hi 👋
I am really enjoying using lifecycle 👏
I have just found an "inconsistency" in the warnings returned:
- past tense for deprecated function: "[..] was deprecated in [..]"
- present tense for deprecated argument: "[..] is deprecated as of [..]"
Shouldn't be always the same tense?
See reprex, where lifecycle 1.0.4 and R 4.4.1 has been used (Windows OS). Thanks in advance.
library(lifecycle)
a <- function(x) {
lifecycle::deprecate_warn(when = "1.0.0",
what = "a()",
with = "b()",
always = TRUE
)
lifecycle::deprecate_warn(
when = "1.0.0",
what = "a(x)",
with = "b(y)",
always = TRUE
)
}
# Run the function - returns the warnings
a(x = 1)
#> Warning: `a()` was deprecated in <NA> 1.0.0.
#> ℹ Please use `b()` instead.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.
#> Warning: The `x` argument of `a()` is deprecated as of <NA> 1.0.0.
#> ℹ Please use the `y` argument of `b()` instead.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.
Created on 2024-07-25 with reprex v2.1.0
- Dominant language
- R
- Stars
- 93
- Forks
- 26
- Avg merge
- 4h 7m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from r-lib/lifecycle
-
Always warn when llm Open
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·