qurit / qurit/rt-utils

Not compatible with open-cv < 4.0.0

Open
#45 0 comments 0 reactions 1 assignee View on GitHub

@plesqui is already working on this.

Since Jul 18, 2023.

Dominant language
Python
Stars
256
Forks
75
PR merge metrics
No merged PRs in 30d

Description

Hello there!

Great tool. Thank you for making it public :) . I noticed that the tool won't work with open-cv < 4.0.0. In particular, this line: https://github.com/qurit/rt-utils/blob/main/rt_utils/image_helper.py#L90 will return an error because cv.findContours returns a tuple of three elements in open-cv < 4.0.0 (e.g., see -> https://docs.opencv.org/3.4.17/d3/dc0/group__imgproc__shape.html#ga95f5b48d01abc7c2e0732db24689837b for 3.4.17). That behaviour changed in 4.0.0.

I am not sure if there are other backward compatibility issues.

I would suggests updating the requirements file to enforce a version of open-cv >= 4.0.0 (or whichever version the tests were run on) so that if the existing python environment already contains an old version of open-cv, this gets also updated.

My best regards,

P

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.