quarto-dev / quarto-dev/quarto-cli

`quarto render` to a named pipe hangs

Offen
#635 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

enhancement
Vorherrschende Sprache
JavaScript
Sterne
6k
Forks
458
Ø Merge
1 T. 9 Std.
Gemergte PRs (30 T.)
41

Beschreibung

I think what's happening is that we're assuming these are actual files, and Deno.readTextFileSync() hangs (I can't even ctrl-c my way out of the deno process.) If I rm the named pipe, then the next ctrl-c yields an error deep inside the html postprocessors:

NotFound: No such file or directory (os error 2), open 'a-pipe'
    at Object.opSync (deno:core/01_core.js:174:12)
    at openSync (deno:runtime/js/40_files.js:39:22)
    at readFileSync (deno:runtime/js/40_read_file.js:11:18)
    at Object.readTextFileSync (deno:runtime/js/40_read_file.js:39:24)
    at runHtmlPostprocessors (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/command/render/render.ts:1038:28)
    at renderPandoc (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/command/render/render.ts:657:39)
    at async Object.onRender (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/command/render/render.ts:860:26)
    at async renderFiles (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/command/render/render.ts:310:9)
    at async render (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/command/render/render-shared.ts:96:18)
    at async Command.fn (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/command/render/cmd.ts:179:26)

it seems hard to handle this correctly in general, so we should probably refuse to render to an existing location if we're in a unix system and we detect that a named pipe exists there.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Start in src/command/render/render.ts, especially runHtmlPostprocessors and the renderPandoc call shown in the stack trace. Reproduce rendering to an existing Unix named pipe and inspect how Deno.readTextFileSync() is reached. Done means the CLI refuses this destination instead of hanging, with the behavior limited to the stated Unix named-pipe case.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
deno, javascript
Bereich
cli
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.