pyvec / pyvec/naucse.python.cz

Arca backend used in tests

Open
#519 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
335
Forks
119
Avg merge
3h 6m
Merged PRs (30d)
1

Description

So I was looking at the failing test in test_arca_render and at first, I also had no clue what the problem is... But then after crawling through the logs and some experiments, I found the issue: the test is being run with arca.backend.CurrentEnvironmentBackend and the current environment has got naucse-render installed.

I really struggled to find why the hell CurrentEnvironmentBackend is used even though VenvBackend is configured in the tests (and even when I set the environ variable), but I finally found it in pytest.ini, the environ there overrides the VenvBackend in tests and even the backend provided in CLI.

I'm not exactly sure what backend you actually want to run it with so I'm not making a PR.
Also, just as a heads up, VenvBackend does not work on Travis (https://github.com/travis-ci/travis-ci/issues/8589, issue closed because it was stale, but AFAIK still not resolved)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pytest.ini and the failing test_arca_render, then trace how the configured backend overrides VenvBackend and the CLI setting. Confirm with maintainers which backend the tests should use; done means the intended backend is selected consistently and test_arca_render no longer runs against an unintended current-environment backend.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.