Feedback
Ouverte
@goldsborough y travaille déjà.
Depuis le 8/10/2018.
- Langage dominant
- HTML
- Étoiles
- 255
- Forks
- 37
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Hey, I just did a simple integration of libtorch as an addon for nodejs. The API worked very nice and I really enjoyed the design, it's very well done ! I'm adding in this issue some feedbacks (don't know if here is the best place, but here you go):
- The
torch::jit::loadisn't exposed by just adding thetorch/torch.hheader, you have to include thetorch/script.has well, don't know if it is intentional but it took me some time to find the right header, maybe a documentation improvement could help; - There are some local paths hardcoded into the ATen cmake files, such as in
share/cmake/ATen/ATenConfig.cmake:/Users/administrator/nightlies/2018_10_01/wheel_build_dirs/libtorch_2.7/pytorch/torch/lib/tmp_install/include; - Documentation is still missing some parts, especially regarding loading TorchScript, etc. Given that a lot of people will start to use the libtorch, I would be nice to have a expanded documentation on ATen/Torch API with some examples (I can contribute as well);
- Problem when seeing the docs for the
torch::jit::load(https://pytorch.org/cppdocs/api/function_namespacetorch_1_1jit_1ace2c44fb8af5905ae17834e81086b8a3.html#exhale-function-namespacetorch-1-1jit-1ace2c44fb8af5905ae17834e81086b8a3) - Many broken broken in the initial page of the docs (
torch::nn,torch::optim,torch::data,torch::serialize,torch::jitandtorch::python)
This is what I remember, if I see anything else I'll add it here as well.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Évaluation
Cette issue n'a pas encore été évaluée.