Spec for subtypes of type variable constraints too vague
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 1.8k
- Forks
- 302
- Merge medio
- 23 h
- PR fusionados (30 d)
- 8
Descripción
The spec is very vague when it comes to instantiating a type variable with constraints with a subtype of one of the constraints:
Let's look at a slightly more involved example:
class C[T: (int, str)]:
def __init__(self, t: T) -> None:
self.t: T = t
c = C(True)
The example in the spec implies that the constructor call is fine because True is of type bool, which is a subtype of int, and T can be instantiated to int. Thus, c should have type C[int]. This makes perfect sense and is totally natural if you write a bidirectional type checker anyway. Nothing controversial here.
What about the following?
c: C[bool] = ...
Does the type "widening" to the base type mentioned in the spec apply here too and this has to be interpreted as if the user had written C[int]? At least pyright interprets it this way. I'm wondering if this was the intent of the spec? Off the top of my head, I cannot think of a situation where this would be a useful feature (but I'm happy to convinced otherwise). Moreover, this can become rather counter-intuitive when C[bool] appears in contravariant positions.
I would like to get a conversation going that crystallizes the intent of the spec in this regard. If we come to a conclusion, I'd be more than happy to update the docs to reflect this outcome.
Here's how I would roughly specify the feature:
-
Explicit instantiations of constrained type variables via class/alias specializations must be taken at face value and not automatically be widened to base types. If the explicitly mentioned type argument is neither a type variable nor a type equivalent to one of the constraints, that's a type error. For the exact meaning of "equivalent", I would suggest to pick an equivalence relation on the more syntactic side of the spectrum of possibilities but haven't thought about this aspect too deeply so far.
-
Explicitly instantiating a constrained type variable
Twith another type variableSis only allowed ifSalso has constraints and each of them is also listed inT's constraints (up to the same equivalence as above). (I avoided the word "subset" on purpose since that's too easy to interpret as "subtype", which I do not mean!) -
All of this this should also apply to generic functions should there ever be a way to explicitly specialize them.
-
When inferring type arguments for generic function calls, including constructor calls, the function is conceptually "exploded" into an overloaded function with one case for each constraint and overload resolution decides which constraint to pick as the instantiation for the type variable.
This gets particularly gnarly in the presence of multiple matching constraints caused by multiple inheritance. Being consistent with overload resolution seems like a good property to have here.
This covers the covariant case illustrated in the example above where
boolgets "widened" toint. It also covers the contravariant case, where the functiondef higher_order[T: (int, str)](f: Callback[[T], None]): ...can be called with an argument of type
Callback[[float], None]andTgets instantiated toint. (In some sense,floatgets "narrowed" tointhere.)
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con docs/spec/generics.rst, especialmente con la sección enlazada sobre variables de tipo restringidas, y revisa los ejemplos relacionados con C[bool], la inferencia de constructores y las posiciones contravariantes. Lee las cuatro reglas propuestas y la discusión existente en los comentarios antes de determinar la semántica prevista. Se considera terminado cuando se haya llegado a un acuerdo y se haya actualizado la especificación para indicar claramente el comportamiento.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- documentation
- Tipo de issue
- Documentación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 35/100