python / python/typeshed

unittest.mock.patch(): Use `class` for `DEFAULT`

Open
#4,968 0 comments 0 reactions 1 assignee View on GitHub

@srittau is already working on this.

Since Jan 24, 2021.

Dominant language
Python
Stars
5.1k
Forks
2.1k
Avg merge
1d 19h
Merged PRs (30d)
82

Description

Idea by hauntaninja in #4824:

class DEFAULT: ...
def __init__(self: _patch[Any], ..., new: Type[DEFAULT], ...)

This allows us to add an overload to patch() for patch[MagicMock].

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.