[rasterio] `transform.rowcol` return typing possibly incorrect?
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5.1k
- Forks
- 2.1k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 82
Description
From what we expect and what the docstring of this method says in rasterio, I believe the return typing isn't strictly int it can be floats? Please could someone double check to verify?
https://github.com/rasterio/rasterio/blob/main/rasterio/transform.py#L295
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading rasterio/transform.py around line 295 and compare the rowcol docstring with its runtime behavior. Then locate the corresponding typeshed stub and its tests, verify whether float results are possible, and update the declared return type if needed so the stub matches the implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100