python / python/typeshed

Missing reflected dunder methods from AbstractSet

Abierto
#15,532 0 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Python
Estrellas
5.1k
Forks
2.1k
Merge medio
1 d 19 h
PR fusionados (30 d)
82

Descripción

Problem

Reflected operations (__rand__, __ror__, __rsub__, __rxor__) are missing from AbstractSet and its subclasses.

These are noted as explicit exclusions from tests: https://github.com/python/typeshed/blob/9f8f621918e4a187c49d68290a89f5f3dbe0cba9/stdlib/%40tests/stubtest_allowlists/common.txt#L50-L54

Example of consequences

@samueljsb and I have defined a protocol (in another project) for an object which has an __rsub__ method, and discovered that set, despite implementing this method, does not adhere to the protocol.

A simplified illustration of this issue is:

from typing import Any, Protocol

class Subtractable(Protocol):
    def __rsub__(self, other: Any) -> Any: ...

_: Subtractable = set()
$ mypy t.py
t.py:6: error: Incompatible types in assignment (expression has type "set[Never]", variable has type "Subtractable")  [assignment]
Found 1 error in 1 file (checked 1 source file)

Demonstrated with:

  • mypy 1.19.1 (compiled: yes)
  • Python 3.14.2 (main, Dec 5 2025, 16:49:16) [Clang 17.0.0 (clang-1700.4.4.1)]

Investigation

The exclusions reference https://github.com/python/typeshed/issues/7414, which was an attempt to add type hints for them. It was closed without merging because it encountered errors. We believe it encountered errors because the type signatures were wrong. Specifically, it didn't account for the return types of the operations matching the inputs.

For example, instead of:

def __rsub__(self, s: AbstractSet[_T]) -> AbstractSet[_T]: ...

We believe the signature needs to be (in the new syntax):

def __rsub__[T_Set: AbstractSet](self, other: T_Set) -> T_Set: ...

The above can be applied to __rsub__ and __rand__, because those methods return a subset of the input, and therefore will not change its type.

__ror__ and __rxor__ are more complicated because they return a type which is a superset of both inputs. We haven't yet looked into how to solve those.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con las exclusiones de stdlib/@tests/stubtest_allowlists/common.txt y compara la implementación de AbstractSet en Lib/_collections_abc.py de CPython. Rastrea los stubs y las subclases de AbstractSet, determina firmas compatibles para los cuatro métodos reflejados y confirma después que las exclusiones se pueden eliminar mientras pasan las pruebas de stub relevantes.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
devtools
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.