Only Try a Unique Venv If There Is a Conflict
未关闭
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 1k
- 派生
- 203
- 平均合并
- 1 小时 20 分钟
- 30 天内合并 PR
- 2
描述
Currently any failure when installing a benchmark's requirements triggers the creation of a unique venv for that benchmark and a retry of the install. The only failure for which we need to create a unique venv is when there is a conflict with the version of already installed packages. Adjusting the code along those lines would speed things up when their are failures (e.g. wheel cannot build) and produce less noise.
Possible solutions:
- parse the text of the first install attempt to see if it a conflict
- this is fragile, as well as requiring that we "tee" the output of the "pip install" command
- instead of trying the common venv first, track the installed versions and use the common venv only if the benchmark's requirements are compatible
- #158 identifies several approaches to tracking installed versions
- this means we need to add some logic for checking requirements compatibility, though there is probably a good enough library out there (maybe in the stdlib)
Also see https://github.com/python/pyperformance/issues/144#issuecomment-1075822776.
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
跟踪 benchmark 的 requirements 安装流程,并查看 issue #158,了解跟踪已安装版本的方法。当仅针对软件包版本冲突使用唯一的虚拟环境,而其他安装失败在不自动重试的情况下报告时,此更改即完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- performance, tooling
- Issue 类型
- 重构
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 38/100