python / python/pyperformance

Commands fail if --manifest is a relative path.

Abierto
#125 2 comentarios 0 reacciones 1 asignado Ver en GitHub

@ericsnowcurrently ya está trabajando en esto.

Desde el 20/1/2022.

Lenguaje dominante
Python
Estrellas
1k
Forks
203
Merge medio
1 h 20 min
PR fusionados (30 d)
2

Descripción

$ # python3 -m pyperformance list --manifest pyperformance/data-files/benchmarks/MANIFEST
$ python3 -m pyperformance list --manifest ./pyperformance/data-files/benchmarks/MANIFEST
switching to a venv.
...

Traceback (most recent call last):
  File "<py-install>/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "<py-install>/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "<pyperformance-root>/pyperformance/__main__.py", line 2, in <module>
    pyperformance.cli.main()
  File "<pyperformance-root>/pyperformance/cli.py", line 308, in main
    _main()
  File "<pyperformance-root>/pyperformance/cli.py", line 294, in _main
    benchmarks = _benchmarks_from_options(options)
  File "<pyperformance-root>/pyperformance/cli.py", line 224, in _benchmarks_from_options
    manifest = _manifest_from_options(options)
  File "<pyperformance-root>/pyperformance/cli.py", line 218, in _manifest_from_options
    return _manifest.load_manifest(options.manifest)
  File "<pyperformance-root>/pyperformance/_manifest.py", line 28, in load_manifest
    return BenchmarksManifest._from_sections(sections, resolve, filename)
  File "<pyperformance-root>/pyperformance/_manifest.py", line 69, in _from_sections
    self._add_sections(sections, resolve)
  File "<pyperformance-root>/pyperformance/_manifest.py", line 113, in _add_sections
    for filename, section, data in sections:
  File "<pyperformance-root>/pyperformance/_manifest.py", line 279, in _parse_manifest_file
    filename = _utils.resolve_file(filename, relroot)
  File "<pyperformance-root>/pyperformance/_utils.py", line 64, in resolve_file
    raise NotImplementedError(relroot)
NotImplementedError: ./pyperformance/data-files/benchmarks

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.