Commands fail if --manifest is a relative path.
Open
@ericsnowcurrently is already working on this.
Since Jan 20, 2022.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 203
- Avg merge
- 1h 20m
- Merged PRs (30d)
- 2
Description
$ # python3 -m pyperformance list --manifest pyperformance/data-files/benchmarks/MANIFEST
$ python3 -m pyperformance list --manifest ./pyperformance/data-files/benchmarks/MANIFEST
switching to a venv.
...
Traceback (most recent call last):
File "<py-install>/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "<py-install>/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "<pyperformance-root>/pyperformance/__main__.py", line 2, in <module>
pyperformance.cli.main()
File "<pyperformance-root>/pyperformance/cli.py", line 308, in main
_main()
File "<pyperformance-root>/pyperformance/cli.py", line 294, in _main
benchmarks = _benchmarks_from_options(options)
File "<pyperformance-root>/pyperformance/cli.py", line 224, in _benchmarks_from_options
manifest = _manifest_from_options(options)
File "<pyperformance-root>/pyperformance/cli.py", line 218, in _manifest_from_options
return _manifest.load_manifest(options.manifest)
File "<pyperformance-root>/pyperformance/_manifest.py", line 28, in load_manifest
return BenchmarksManifest._from_sections(sections, resolve, filename)
File "<pyperformance-root>/pyperformance/_manifest.py", line 69, in _from_sections
self._add_sections(sections, resolve)
File "<pyperformance-root>/pyperformance/_manifest.py", line 113, in _add_sections
for filename, section, data in sections:
File "<pyperformance-root>/pyperformance/_manifest.py", line 279, in _parse_manifest_file
filename = _utils.resolve_file(filename, relroot)
File "<pyperformance-root>/pyperformance/_utils.py", line 64, in resolve_file
raise NotImplementedError(relroot)
NotImplementedError: ./pyperformance/data-files/benchmarks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.