@overload interacts badly with @property even with the `type: ignore` workaround
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 20.6k
- Forks
- 3.3k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Assuming a issue.py module:
$ mypy issue.py
issue.py:86: error: Invalid self argument "MyContainerStr" to attribute function "bounds" with type "Callable[[MyContainerBase[int]], BoundsInt]"
issue.py:86: error: Argument 1 to "check_to_str_bounds" has incompatible type "BoundsInt"; expected "BoundsStr"
Found 2 errors in 1 file (checked 1 source file)
This occurs when I attempt to overload a property. It however does not occurs for the same overload on a plain method.
issue.py is:
from typing import (ClassVar, Generic, NamedTuple, Optional, Type, TypeVar,
Union, overload)
BoundsInt = NamedTuple("BoundsInt", [
("begin", int), ("end", int)])
BoundsStr = NamedTuple("BoundsStr", [
("begin", str), ("end", str)])
_T = TypeVar("_T", int, str)
class MyContainerBase(Generic[_T]):
BOUND_TYPE = None # type: ClassVar[Optional[Type[Union[BoundsInt, BoundsStr]]]] # noqa
def __init__(self, begin: _T, end: _T) -> None:
assert self.BOUND_TYPE is not None
if isinstance(begin, int) and isinstance(end, int):
self._bounds = BoundsInt(begin, end) # type: Union[BoundsInt, BoundsStr] # noqa
assert isinstance(begin, str) and isinstance(end, str)
self._bounds = BoundsStr(begin, end)
@overload # type: ignore
@property
def bounds(
self: 'MyContainerBase[int]'
) -> BoundsInt:
...
@overload # type: ignore
@property
def bounds(
self: 'MyContainerBase[str]'
) -> BoundsStr:
...
@property
def bounds(self) -> Union[BoundsInt, BoundsStr]:
"""Return the recurrence period's bounds."""
return self._bounds
@overload
def get_bounds(
self: 'MyContainerBase[int]'
) -> BoundsInt:
...
@overload
def get_bounds(
self: 'MyContainerBase[str]'
) -> BoundsStr:
...
def get_bounds(self) -> Union[BoundsInt, BoundsStr]:
"""Return the recurrence period's bounds."""
return self._bounds
class MyContainerInt(MyContainerBase[int]):
BOUND_TYPE = BoundsInt
class MyContainerStr(MyContainerBase[str]):
BOUND_TYPE = BoundsStr
def test() -> None:
def check_to_int_bounds(bounds: BoundsInt) -> None:
pass
def check_to_str_bounds(bounds: BoundsStr) -> None:
pass
# Typechecks as expected:
check_to_int_bounds(MyContainerInt(1, 1).bounds)
# As expected, if uncommented, fails with:
# Argument 1 to "check_to_str_bounds" has incompatible type "BoundsInt";
# expected "BoundsStr"
# check_to_str_bounds(MyContainerInt(1, 1).bounds)
# Unexpectedly, if uncommented both of those fail with:
# Invalid self argument "MyContainerStr" to attribute
# function "bounds" with type "Callable[[MyContainerBase[int]],
# BoundsInt]"
check_to_str_bounds(MyContainerStr("a", "b").bounds)
# check_to_int_bounds(MyContainerStr(1.0, 1.0).bounds)
# We do not have the above issue with the `get_bounds` method:
# Typechecks as expected:
check_to_int_bounds(MyContainerInt(1, 1).get_bounds())
# As expected, if uncommented, fails.
# check_to_str_bounds(MyContainerInt(1, 1).get_bounds())
# Typechecks as expected:
check_to_str_bounds(MyContainerStr("a", "b").get_bounds())
# As expected, if uncommented, fails.
# check_to_int_bounds(MyContainerStr(1.0, 1.0).get_bounds())
Your Environment
- Mypy version used: 0.790
- Mypy command-line flags: none
- Mypy configuration options from
mypy.ini(and other config files):
[mypy]
warn_unused_ignores = True
mypy_path = distropmc
disallow_any_generics = True
- Python version used: 3.5.9
- Operating system and version:
$ uname -a
Linux rgauthier-precision 5.4.79 #1-NixOS SMP Sun Nov 22 09:14:12 UTC 2020 x86_64 GNU/Linux
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce los diagnósticos con el ejemplo issue.py proporcionado usando mypy 0.790 y, a continuación, sigue cómo se procesan las propiedades sobrecargadas en comparación con los métodos sobrecargados. Se considera terminado cuando el ejemplo de la propiedad supera la comprobación de tipos para las especializaciones genéricas correspondientes y sigue rechazando los casos no coincidentes BoundsInt y BoundsStr.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- devtools
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100