python / python/mypy

`!= (None, None)` Narrowing only in else branch

Open
#21,598 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature topic-type-narrowing
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

Bug Report

!= (None, None) correctly narrows the else branch to tuple[None, None] but, doesn't narrow the union in the if branch.

To Reproduce

a: tuple[int, str] | tuple[None, None]

if a != (None, None):
    reveal_type(a)  #  Revealed type is "tuple[int, str] | tuple[None, None]"
else:
    reveal_type(a)  #  Revealed type is "tuple[None, None]"

Expected Behavior

The if branch should narrow to tuple[int, str]

Actual Behavior

The if branch is tuple[int, str] | tuple[None, None]

Your Environment

  • Mypy version used: 2.1
  • Mypy command-line flags:
  • Mypy configuration options from mypy.ini (and other config files):
  • Python version used:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue's tuple-union example and inspect mypy's type-narrowing handling for inequality comparisons. Add or update a regression test for a != (None, None); done means the if branch reveals tuple[int, str] while the else branch remains tuple[None, None].

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.